Lowercase GHCR image repository name in docker builds#159
Merged
Conversation
The DecaturMakers org name contains an uppercase letter, but Docker/GHCR
repository names must be lowercase. Building tags directly from
${{ github.repository }} produced an invalid tag
(ghcr.io/DecaturMakers/machine-access-control:...) and failed the build.
Add a step that lowercases $GITHUB_REPOSITORY via bash parameter
expansion and reference its output in the image tags, in both the
tests.yml docker job and the release.yml publish job. The OCI image
labels (URLs) are left as-is since GitHub URLs are case-insensitive.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker test build is failing on
mainafter the org transfer:The
DecaturMakersorg name has an uppercase letter, but Docker/GHCR repository names must be lowercase. The workflows built image tags directly from${{ github.repository }}, which carries the uppercase org name.Fix
Add a step that lowercases
$GITHUB_REPOSITORYvia bash parameter expansion (${GITHUB_REPOSITORY,,}) and reference its output in theghcr.io/...tags, in both:tests.yml— thedockerjob (SHA-tagged build)release.yml— the publish job (:<tag>and:latest)The OCI image labels (
org.opencontainers.image.url/source) are left as-is since they're GitHub URLs and case-insensitive.Notes
docker pull ghcr.io/...in docs/README/compose), so no docs change is needed. The published image will beghcr.io/decaturmakers/machine-access-control(lowercase).0.14.0tag is pushed, since the release build is triggered by the tag and readsrelease.ymlfrom the tagged commit.🤖 Generated with Claude Code